Add tooltip above Start Execution button
#1802
Conversation
jamie-suse
added
enhancement
|
One thing to note is that if you save some new checks in Host Checks Selection, then click the Start Execution button, the tooltip disappears as intended. After if you then navigate back to Host Details page, the tooltip will appear again - instead of being hidden because the user has already executed the checks. Do you think this is a big issue? Screencast.from.2023-09-11.12-54-19.webm |
There was a problem hiding this comment.
Great job so far!
Just a quick recap of the offline discussion:
- host check selection and cluster check selection should have the same ux/ui regarding the tooltip
- host detail and cluster detail should have the same ux/ui (ie Select some checks first tooltip and should the
Click Start Execution or wait for ...tooltip be there in that page?) - enabled/disabled button ui consitency between cluster/host detail/selection
jamie-suse
force-pushed
the
checks-execution-tooltip
branch
from
d308f77 to
28fa39c
Compare
| @@ -23,6 +24,7 @@ function HostChecksSelection({ | |||
| onSelectedChecksChange, | |||
| hostChecksExecutionEnabled, | |||
| onStartExecution = () => {}, | |||
| checksExecutionTooltipVisible, | |||
There was a problem hiding this comment.
Could you rename this to isExecutionTooltipVisible?
| @@ -29,6 +29,8 @@ function HostSettingsPage() { | |||
| setSelection(hostSelectedChecks); | |||
| } | |||
| }, [hostSelectedChecks]); | |||
| const [checksExecutionTooltipVisible, setChecksExecutionTooltipVisible] = | |||
There was a problem hiding this comment.
hostSelectedChecks should update itself reactively if I remember correctly, did you check if you actually need a state here?
There was a problem hiding this comment.
Good point 👍 removed this
jamie-suse
force-pushed
the
checks-execution-tooltip
branch
2 times, most recently
from
3fdf8a6 to
4e7cbc7
Compare
jamie-suse
force-pushed
the
checks-execution-tooltip
branch
from
4e7cbc7 to
b4ff564
Compare
Description
This PR present 3 main visual changes:
Checks Selection tooltip
Adds a tooltip above the
Start Executionbutton in the Cluster Settings and Host Checks Selection pages that says:If no checks or no new checks are saved on the page, this tooltip does not appear.
Host Details page tooltip
This PR also adds the tooltip for
that appears below the
Start Executionbutton in the Host Details page; in order ot align the behaviour as seen in the Cluster Details page.Align Cluster Details page
This PR also aligns the styling of the
Start Executionbutton in the Cluster Details page with the rest of the app.How was this tested?
Added assertions in React component tests to test appearance/disappearance of tooltip.
Updated Storybooks.