Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix instance movement logic #1810

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Fix instance movement logic #1810

merged 1 commit into from
Sep 12, 2023

Conversation

arbulu89
Copy link
Contributor

Description

Fix instance movement logic.

  • If the instance with same number, host and features exist -> nop
  • The instance finding matching updated to check the features as well

How was this tested?

UT test added together with manual testing

@arbulu89 arbulu89 added bug Something isn't working env Create an ephimeral environment for the pr branch labels Sep 12, 2023
@arbulu89 arbulu89 requested a review from CDimonaco September 12, 2023 07:40
@arbulu89
Copy link
Contributor Author

Tested with @abravosuse in a real env and it worked as expected

@arbulu89 arbulu89 marked this pull request as ready for review September 12, 2023 08:58
CDimonaco
CDimonaco approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@CDimonaco CDimonaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arbulu89 arbulu89 merged commit 018e29c into main Sep 12, 2023
@arbulu89 arbulu89 deleted the avoid-not-needed-instance-movement branch September 12, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CDimonaco CDimonaco CDimonaco approved these changes

Assignees
No one assigned
Labels
bug Something isn't working env Create an ephimeral environment for the pr branch
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arbulu89 @CDimonaco