Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saptune services status icons #1906

Merged
merged 7 commits into from
Oct 9, 2023
Merged

Conversation

EMaksy
Copy link
Member

@EMaksy EMaksy commented Oct 5, 2023

Description

Adding Saptune Service Status icons

Demo

image

How was this tested?

Added automated test

@EMaksy EMaksy added enhancement New feature or request javascript Pull requests that update Javascript code env Create an ephimeral environment for the pr branch labels Oct 5, 2023
@EMaksy EMaksy self-assigned this Oct 5, 2023
@EMaksy EMaksy marked this pull request as ready for review October 5, 2023 11:37
Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to adjust the tests

@EMaksy EMaksy force-pushed the saptune-details-view-status-icons branch from 986cca5 to d6c0387 Compare October 5, 2023 13:37
Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions @EMaksy

@EMaksy EMaksy force-pushed the saptune-details-view-status-icons branch 4 times, most recently from dcc788c to d0bad08 Compare October 6, 2023 13:07
Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More things

@EMaksy EMaksy force-pushed the saptune-details-view-status-icons branch 2 times, most recently from b60eca3 to 23ee349 Compare October 9, 2023 10:32
@EMaksy EMaksy requested a review from arbulu89 October 9, 2023 11:16
Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okey!
All good now.
Some minimal changes, but you can merge without other review.

@EMaksy EMaksy force-pushed the saptune-details-view-status-icons branch from 23ee349 to 88df153 Compare October 9, 2023 11:46
@EMaksy EMaksy merged commit 0acae79 into main Oct 9, 2023
24 checks passed
@EMaksy EMaksy deleted the saptune-details-view-status-icons branch October 9, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request env Create an ephimeral environment for the pr branch javascript Pull requests that update Javascript code
Development

Successfully merging this pull request may close these issues.

2 participants