-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Saptune services status icons #1906
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to adjust the tests
986cca5
to
d6c0387
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions @EMaksy
assets/js/components/SaptuneDetails/SaptuneServiceStatus.test.jsx
Outdated
Show resolved
Hide resolved
assets/js/components/SaptuneDetails/SaptuneServiceStatus.test.jsx
Outdated
Show resolved
Hide resolved
dcc788c
to
d0bad08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More things
assets/js/components/SaptuneDetails/SaptuneServiceStatus.test.jsx
Outdated
Show resolved
Hide resolved
b60eca3
to
23ee349
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okey!
All good now.
Some minimal changes, but you can merge without other review.
assets/js/components/SaptuneDetails/SaptuneServiceStatus.test.jsx
Outdated
Show resolved
Hide resolved
assets/js/components/SaptuneDetails/SaptuneServiceStatus.test.jsx
Outdated
Show resolved
Hide resolved
23ee349
to
88df153
Compare
Description
Adding Saptune Service Status icons
Demo
How was this tested?
Added automated test