Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notify user when cluster health changes #1908

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Notify user when cluster health changes #1908

merged 3 commits into from
Oct 6, 2023

Conversation

jamie-suse
Copy link
Contributor

Description

This change notifies the user when a cluster's health changes.

Changes made:

  • Created a new Phoenix view cluster_health_changed.json to use when broadcasting the cluster_health_changed websocket event.
  • This view now also contains the cluster name as well as the previous cluster ID and health. The cluster name is required when displaying the notification to the user
  • The Saga watching for the cluster_health_changed websocket event now displays a notification to the user stating that the cluster's health has changed

How was this tested?

  • Added test for new Phoenix view cluster_health_changed.json
  • Updated projector test
  • Added test for Saga

@jamie-suse jamie-suse added enhancement New feature or request javascript Pull requests that update Javascript code elixir Pull requests that update Elixir code labels Oct 5, 2023
@jamie-suse jamie-suse marked this pull request as ready for review October 6, 2023 08:17
dottorblaster
dottorblaster approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jamie-suse jamie-suse merged commit 1a355f9 into main Oct 6, 2023
24 checks passed
@jamie-suse jamie-suse deleted the cluster-health-change-notif branch October 6, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsonkopliku nelsonkopliku nelsonkopliku approved these changes

@dottorblaster dottorblaster dottorblaster approved these changes

Assignees
No one assigned
Labels
elixir Pull requests that update Elixir code enhancement New feature or request javascript Pull requests that update Javascript code
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamie-suse @dottorblaster @nelsonkopliku