Implement sagas for save and upsate of SUMA settings #2338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottorblaster
force-pushed
the
implement-sagas-suma-settings-save-update
branch
from
336ba43 to
79fe397
Compare
dottorblaster
force-pushed
the
implement-sagas-suma-settings-save-update
branch
from
79fe397 to
f2045cf
Compare
nelsonkopliku
approved these changes
Feb 20, 2024
| password: faker.word.noun(), | ||
| ca_cert: '', | ||
| }; | ||
| const errors = [ |
There was a problem hiding this comment.
OCD alert: mismatching errors based on the input.
Providing an empty username username: '', would result in an extra error besides url/ca_cert.
Feel free to keep like this, tho 😄 The test still tests what it's supposed to test.
| }); | ||
|
|
||
| describe('Updating Software Updates settings', () => { | ||
| it('should successfully save software updates settings', async () => { |
There was a problem hiding this comment.
maybe a copy/pasta from previous test
Suggested change
| it('should successfully save software updates settings', async () => { | |
| it('should successfully change software updates settings', async () => { |
| ]); | ||
| }); | ||
|
|
||
| it('should have errors on failed saving', async () => { |
There was a problem hiding this comment.
Suggested change
| it('should have errors on failed saving', async () => { | |
| it('should have errors on failed update', async () => { |
jamie-suse
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As above, just implementing the sagas to save and update SUMA settings 👍
How was this tested?
Jest tests