-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Api key expiration checking routine #2384
Conversation
efb1ab6
to
965fbde
Compare
965fbde
to
6866c25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
Just some nitpick comments
lib/trento/infrastructure/alerting/emails/templates/api_key_expiration.html.eex
Show resolved
Hide resolved
lib/trento/infrastructure/alerting/emails/templates/api_key_expiration.html.eex
Outdated
Show resolved
Hide resolved
lib/trento/infrastructure/alerting/emails/templates/api_key_expiration.html.eex
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code apart, it looks good to me @CDimonaco !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (wasn't able to review in time but still all looks good)
Description
This PR adds a new quantum routine to check each day if the api key is expired.
When the api key expiration is less then 30 days, an email is sent.
When the api key expires an email is sent.
The email are sent until the api key is generated again with a new expiration.
No email are sent if the api key expiration is infinite
How was this tested?
Automated tests