Add checks catalog view #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
requested review from
dottorblaster,
fabriziosestito,
rtorrero,
stefanotorresi and
nelsonkopliku
arbulu89
force-pushed
the
add-checks-catalog-view
branch
from
5bd7a4f to
4c3495a
Compare
|
@arbulu89 would it be possible to preserve the code blocks around the parameters in the description, like it was before? |
arbulu89
force-pushed
the
add-checks-catalog-view
branch
from
74c4243 to
931ca4d
Compare
dottorblaster
approved these changes
Mar 25, 2022
nelsonkopliku
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks catalog view.
I have changed the catalog json struct. Have a look please. If you like it, I would change the runner to create that struct.
Now, the checks catalog can be updated based on the provider. The data is loaded at initialization, so we wouldn't have real updates if the catalog is changed in the runner.
I didn't update the package-lock.json file, as I think I have a different npm version, and it changes the whole file...*
This is just a frontend work. It doesn't do anything in the backend. We will discuss about this afterwards.