Avoid SUMA health complete on settings not configured error

[arbulu89]

Description

Avoid sending CompleteSoftwareUpdatesDiscovery during the discovery if the SUMA settings are not configured.
This is needed in scenarios like when the SoftwareUpdatesDiscoveryEventHandler handler runs the discovery.
Without this change, the health of the software updates is set to unknown, even though we shouldn't be changing it, as SUMA settings are not configured.

So the unique difference is that the settings_not_configured error doesn't dispatch the command, nothing else.

How was this tested?

UT added and tested manually

[nelsonkopliku]

Thanks @arbulu89.
Have you considered implementing a command middleware doing this check every time a CompleteSoftwareUpdatesDiscovery is dispatched?

I would have implemented it that way, however I can live with this as well.

[arbulu89]

@nelsonkopliku No, I didn't consider that.
How would you do that? Querying the database every time we have this command?
It looks like less efficient. As we already have the value, why not just simply use it?

[nelsonkopliku]

Yes, maybe some extra tiny query when that command would be dispatched 🙈

Your proposed solution is just fine, at the end when that command gets dispatched a discovery (read attempt to call suma) have already happened, so we wouldn't be blocking anything interesting in such a middleware.

[dottorblaster]

LGTM 👍