-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SAP systems policy receiving an empty list of instances #2677
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @dottorblaster.
The change was introduced here https://github.com/trento-project/web/pull/2214/files, along with other required: true
.
I am not sure if any other of those would cause issues.
@dottorblaster, if you don't mind, may I just ask to fix this typo making the CI red, please? https://github.com/trento-project/web/actions/runs/9413405002/job/25930084979?pr=2677 |
@nelsonkopliku YES |
0046ce9
to
4743f37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @dottorblaster, LGTM.
As long as @abravosuse's test is successful and @CDimonaco is fine with this, let's ship it.
@dottorblaster Thank you. Our e2e tests check that the cleanup button is there when there is a complete removal of the SAP instance in the agent host, which causes a different payload. I don't know if we should update the e2e tests, as you added this UT test here, but we have this gap there... |
Description
Fix SAP systems policy receiving an empty list of instances and marking that as not valid, thus making impossible in some cases to deregister an existing system.
How was this tested?
Existing unit tests passing, added a unit test to make sure this doesn't incur again