Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename TRENTO_DOMAIN to TRENTO_WEB_ORIGIN #2682

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Rename TRENTO_DOMAIN to TRENTO_WEB_ORIGIN #2682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8ae031
Rename TRENTO_DOMAIN to TRENTO_WEB_ORIGIN
nelsonkopliku Jun 7, 2024
736d69f
adjust helm value
nelsonkopliku Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -752,7 +752,7 @@ jobs:
)
env:
IMAGE_REPOSITORY: ghcr.io/${{ github.repository_owner }}
TRENTO_DOMAIN: ${{ secrets.TRENTO_DEMO_IP }}
TRENTO_WEB_ORIGIN: ${{ secrets.TRENTO_DEMO_IP }}
TRENTO_NAMESPACE: ${{ secrets.TRENTO_NAMESPACE }}
TRENTO_ADMIN_EMAIL: ${{ secrets.TRENTO_ADMIN_EMAIL }}
TRENTO_INGRESS_CLASS: ${{ secrets.TRENTO_INGRESS_CLASS }}
Expand Down Expand Up @@ -799,7 +799,7 @@ jobs:
--set trento-wanda.image.pullPolicy=Always \
--set trento-wanda.image.repository="${IMAGE_REPOSITORY}/trento-wanda" \
--set trento-wanda.image.tag="demo" \
--set trento-web.trentoDomain="${TRENTO_DOMAIN}" \
--set trento-web.trentoWebOrigin="${TRENTO_WEB_ORIGIN}" \
-f ../../hack/cert-manager/override-values.yaml

run-photofinish-demo-env:
Expand Down
4 changes: 2 additions & 2 deletions config/runtime.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,9 @@ if config_env() in [:prod, :demo] do
""")

trento_origin =
System.get_env("TRENTO_DOMAIN") ||
System.get_env("TRENTO_WEB_ORIGIN") ||
raise """
environment variable TRENTO_DOMAIN is missing.
environment variable TRENTO_WEB_ORIGIN is missing.
For example: yourdomain.example.com
"""

Expand Down
2 changes: 1 addition & 1 deletion guides/development/environment_variables.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Dig into [./config](https://github.com/trento-project/web/blob/main/config/) dir

**Server**
- `PORT`
- `TRENTO_DOMAIN`
- `TRENTO_WEB_ORIGIN`

**Runner integration**
- `RUNNER_URL`
Expand Down