-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activity log retention time #2690
Conversation
b19a934
to
c85c47a
Compare
c85c47a
to
e9a101a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding some comments for later consideration.
e9a101a
to
0ee0f05
Compare
0ee0f05
to
4835dd2
Compare
hey @gagandeepb, @balanza, I think I have addressed what we discussed:
* Note that this moves possible validation errors one level down in Thanks for the feedbacks! |
end | ||
end | ||
|
||
def down do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realized that while rolling back, only the activity_log_retention_time
field was removed, but the record typed activity_log_settings
remained, meaning that migrating forward again would result in having the activity log settings record with a null
retention time.
In order to avoid unwanted side effects I thought it is reasonable just deleting the whole record.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I just have some thoughts on naming but they're non blocking
Description
Adds the foundation for the activity log settings, specifically retention time.
The context functions can be then used in a controller to expose desired operations.