Add migration to restart the abilities sequence from 3 #2719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CDimonaco
added
enhancement
nelsonkopliku
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Interesting. Would this fix flakiness in tests as well? like here for instance
EDIT: nevermind, the CI says no.
arbulu89
approved these changes
Jun 26, 2024
|
FORCE MERGE, ALL TESTS PASSED, COVERRALS IS DOWN |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR, manually restarts the abilities table primary key sequence from 3.
We forced the ids of the global abilities, with id 1 and id 2.
We need to manually increment the abilities sequence to interact with the records using the postgres sequence mechanism.
Without this change the sequence does not know about record 1 and 2 created, it starts from one, so all the insert will fail.