Fixes DBConnection checkout related flakiness #2731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some flakiness/test failures were being observed due to processes timing out while waiting to checkout the DBConnection during test runs. This config changes tries to fix the issue. From https://hexdocs.pm/db_connection/DBConnection.html#start_link/2-queue-config : Our goal is to wait at most :queue_target for a connection. If all connections checked out during a :queue_interval takes more than :queue_target, then we double the :queue_target. If checking out connections take longer than the new target, then we start dropping messages.
gagandeepb
added
enhancement
gagandeepb
requested review from
a team,
jagabomb,
EMaksy,
dottorblaster,
jamie-suse,
nelsonkopliku,
CDimonaco,
arbulu89 and
janvhs
and removed request for
a team,
jagabomb and
EMaksy
nelsonkopliku
approved these changes
Jul 2, 2024
jamie-suse
approved these changes
Jul 2, 2024
janvhs
approved these changes
Jul 2, 2024
EMaksy
reviewed
Jul 2, 2024
| @@ -12,6 +12,8 @@ config :trento, Trento.Repo, | |||
| hostname: "localhost", | |||
| port: 5433, | |||
| pool: Ecto.Adapters.SQL.Sandbox, | |||
| queue_target: 200, | |||
| queue_interval: 2000, | |||
There was a problem hiding this comment.
lgtm, but I guess this have also some kind of impact on the time of the ci/cd run, right ?
There was a problem hiding this comment.
The tests were timing out while waiting for a db connection to become available. The additional delay is in the order of milliseconds (at most a few seconds). That's locally. The CI impact should be negligible, if any, in my understanding
EMaksy
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some flakiness/test failures were being observed locally due to processes timing out while waiting to checkout a DB connection during test runs. This test config change tries to fix the issue. From https://hexdocs.pm/db_connection/DBConnection.html#start_link/2-queue-config :
Fixes # (issue)
Did you add the right label?
Remember to add the right labels to this PR.
How was this tested?
Describe the tests that have been added/changed for this new behavior.
Did you update the documentation?
Remember to ask yourself if your PR requires changes to the following documentation:
Add a documentation PR or write that no changes are required for the documentation.