Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non existent path #2732

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Fix non existent path #2732

merged 1 commit into from
Jul 2, 2024

Conversation

nelsonkopliku
Copy link
Member

@nelsonkopliku nelsonkopliku commented Jul 2, 2024 •
edited
Loading

Description

Fixing host checks execution request path that is meant to return 403, but goes 404.

Fixes failing CI https://github.com/trento-project/web/actions/runs/9758779367/job/26934132210#step:8:95

@nelsonkopliku nelsonkopliku self-assigned this Jul 2, 2024
@nelsonkopliku nelsonkopliku added the bug Something isn't working label Jul 2, 2024
arbulu89
arbulu89 approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! The fix was on the way in other PR.
Thank you

@arbulu89 arbulu89 added chore and removed bug Something isn't working labels Jul 2, 2024
@nelsonkopliku nelsonkopliku marked this pull request as ready for review July 2, 2024 10:14
gagandeepb
gagandeepb approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@gagandeepb gagandeepb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@nelsonkopliku nelsonkopliku merged commit e881ff3 into main Jul 2, 2024
76 checks passed
@nelsonkopliku nelsonkopliku deleted the fix-forbidden-test branch July 2, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arbulu89 arbulu89 arbulu89 approved these changes

@gagandeepb gagandeepb gagandeepb approved these changes

@CDimonaco CDimonaco Awaiting requested review from CDimonaco

Assignees

@nelsonkopliku nelsonkopliku

Labels
chore
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nelsonkopliku @gagandeepb @arbulu89