Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return CVEs from Errata Details endpoint #2733

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Return CVEs from Errata Details endpoint #2733

merged 2 commits into from
Jul 4, 2024

Conversation

jamie-suse
Copy link
Contributor

Description

This PR adds the ability to return the list of CVEs for a given advisory queried from the v1/software_updates/errata_details/:advisory_name endpoint.

How was this tested?

Updated related unit tests.

Did you update the documentation?

No changes are required for the documentation.

@jamie-suse jamie-suse added enhancement New feature or request elixir Pull requests that update Elixir code labels Jul 2, 2024
@jamie-suse jamie-suse self-assigned this Jul 2, 2024
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nitpick but LGTM

Copy link
Member

@janvhs janvhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jamie-suse jamie-suse requested a review from dottorblaster July 2, 2024 13:40
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamie-suse jamie-suse merged commit c75617d into main Jul 4, 2024
26 checks passed
@jamie-suse jamie-suse deleted the cve-endpoint branch July 4, 2024 08:32
balanza pushed a commit that referenced this pull request Jul 4, 2024
* Return CVEs from `v1/software_updates/errata_details/:advisory_name`

* Create CVE factory
nelsonkopliku added a commit that referenced this pull request Jul 8, 2024
* global error

* Apply suggestions from code review

Co-authored-by: Nelson Kopliku <nelson.kopliku@suse.com>

* format

* Return CVEs from `Errata Details` endpoint (#2733)

* Return CVEs from `v1/software_updates/errata_details/:advisory_name`

* Create CVE factory

* global error

* Apply suggestions from code review

Co-authored-by: Nelson Kopliku <nelson.kopliku@suse.com>

* format

---------

Co-authored-by: Nelson Kopliku <nelson.kopliku@suse.com>
Co-authored-by: Jamie Rodríguez <jamie.rodriguez@suse.com>
balanza added a commit that referenced this pull request Jul 9, 2024
* global error

* Apply suggestions from code review

Co-authored-by: Nelson Kopliku <nelson.kopliku@suse.com>

* format

* Return CVEs from `Errata Details` endpoint (#2733)

* Return CVEs from `v1/software_updates/errata_details/:advisory_name`

* Create CVE factory

* global error

* Apply suggestions from code review

Co-authored-by: Nelson Kopliku <nelson.kopliku@suse.com>

* format

---------

Co-authored-by: Nelson Kopliku <nelson.kopliku@suse.com>
Co-authored-by: Jamie Rodríguez <jamie.rodriguez@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
elixir Pull requests that update Elixir code enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants