-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return CVEs from Errata Details
endpoint
#2733
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor nitpick but LGTM
test/trento_web/controllers/v1/suse_manager_controller_test.exs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Return CVEs from `v1/software_updates/errata_details/:advisory_name` * Create CVE factory
* global error * Apply suggestions from code review Co-authored-by: Nelson Kopliku <nelson.kopliku@suse.com> * format * Return CVEs from `Errata Details` endpoint (#2733) * Return CVEs from `v1/software_updates/errata_details/:advisory_name` * Create CVE factory * global error * Apply suggestions from code review Co-authored-by: Nelson Kopliku <nelson.kopliku@suse.com> * format --------- Co-authored-by: Nelson Kopliku <nelson.kopliku@suse.com> Co-authored-by: Jamie Rodríguez <jamie.rodriguez@suse.com>
* global error * Apply suggestions from code review Co-authored-by: Nelson Kopliku <nelson.kopliku@suse.com> * format * Return CVEs from `Errata Details` endpoint (#2733) * Return CVEs from `v1/software_updates/errata_details/:advisory_name` * Create CVE factory * global error * Apply suggestions from code review Co-authored-by: Nelson Kopliku <nelson.kopliku@suse.com> * format --------- Co-authored-by: Nelson Kopliku <nelson.kopliku@suse.com> Co-authored-by: Jamie Rodríguez <jamie.rodriguez@suse.com>
Description
This PR adds the ability to return the list of CVEs for a given advisory queried from the
v1/software_updates/errata_details/:advisory_name
endpoint.How was this tested?
Updated related unit tests.
Did you update the documentation?
No changes are required for the documentation.