Cleanup abilities/permissions #2734
Conversation
arbulu89
added
enhancement
arbulu89
force-pushed
the
cleanup-abilities
branch
2 times, most recently
from
e70f8cd to
f53662a
Compare
arbulu89
force-pushed
the
cleanup-abilities
branch
from
f53662a to
6d67b71
Compare
| @@ -208,6 +211,7 @@ describe('HostsLists component', () => { | |||
| hostsList: { | |||
| hosts: [host], | |||
| }, | |||
| user: { abilities: [{ name: 'all', resource: 'all' }] }, | |||
There was a problem hiding this comment.
We repeat this very often, an idea could be to define a global const object something like
const superAdminAbilities = { abilities: [{ name: 'all', resource: 'all' }] } or const superAdmin and reuse it --> user: superAdmin,
But i see why we reuse it again and again, so only just an idea :)
There was a problem hiding this comment.
@EMaksy Yeah...
This is true.
I like the idea of having a constant for this, so we can reuse in tests and storybook.
As we have some already going work in parallel, do you mind if we wait until all the frontend PRs are merged to apply this change?
This way, we don't have any sort of conflicts.
Basically, we do a big search/replace once we have all the features done
There was a problem hiding this comment.
Yeah, sure!
We could even define some more user ability roles, so in future if something changes we need to change it only at one place and not everywhere.
But yeah, let's finish up everything else first!
arbulu89
force-pushed
the
cleanup-abilities
branch
from
6d67b71 to
beb7e7d
Compare
There was a problem hiding this comment.
LGTM
Just a nitpick, if you want you can add a controller test that accepts the request when the abilities are present.
Other then all:all ability, we have that in the setup function, but I think it's valuable, pretty easy to create a user on demand with the right ability and test it.
It serves also as docs purpose about the controller usage
Wdyt?
Description
Add host/application instance/database instance cleanup abilities.
The
Clean upis only available when the user has the proper abilities attached.Even though we have a lot of new lines, almost everything is boilerplate and
userAbilitiesmovement in the frontend.