Activity log endpoint #2739
Merged
Activity log endpoint #2739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagandeepb
added
enhancement
gagandeepb
requested review from
nelsonkopliku
and removed request for
nelsonkopliku
balanza
reviewed
Jul 3, 2024
nelsonkopliku
approved these changes
Jul 4, 2024
balanza
reviewed
Jul 4, 2024
| @@ -38,6 +37,12 @@ defmodule Trento.ActivityLog do | |||
| end | |||
| end | |||
|
|
|||
| @spec list_activity_log() :: list(ActivityLog.t()) | |||
| def list_activity_log do | |||
| # This will be made filterable/paginatable in a later PR | |||
There was a problem hiding this comment.
issue: Avoid comments on future implementations
Suggested change
| # This will be made filterable/paginatable in a later PR |
There was a problem hiding this comment.
My intention here was to motivate/justify the use of Repo.all in the following line, which is not very usual. In a way this implementation is partial and I was only drawing attention to this fact.
Small fixes about parentheses of zero arity functions and ordering of aliases in alphabetical order.
- Single view file, instead of two - Adds title field in spec
According to PR comment
gagandeepb
force-pushed
the
activity-log-endpoint
branch
from
c75d8d8 to
9acb3bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements an endpoint for consuming the activity log.
Filtering/pagination is deferred for later work.
No additional docs needed.
Did you add the right label?
Remember to add the right labels to this PR.
How was this tested?
Describe the tests that have been added/changed for this new behavior.
Unit tests
Did you update the documentation?
Remember to ask yourself if your PR requires changes to the following documentation:
Add a documentation PR or write that no changes are required for the documentation.