Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check execution policy e2e tests #2742

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Conversation

CDimonaco
Copy link
Member

Description

Check execution policy e2e tests, clusters and hosts.

How was this tested?

Automated tests

@CDimonaco CDimonaco added enhancement New feature or request test labels Jul 3, 2024
@CDimonaco CDimonaco requested a review from arbulu89 July 3, 2024 14:00
@CDimonaco CDimonaco self-assigned this Jul 3, 2024
Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

cy.login(user.username, password);
});

cy.visit(`/clusters/${availableHanaCluster.id}/settings`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we could have cy.contains('button', 'Start Execution').should('be.enabled');


cy.contains('button', 'Start Execution').should('be.disabled');

cy.contains('button', 'Start Execution').click({ force: true });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mouseover ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not work because the button is disabled :/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So maybe just better to check that the button is disabled?
We already test the tooltip in the unit tests

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the button is disabled because the checks are not selected, and wanda is not integrated and all the steps are missing, so I simply check that the tooltip it's not present, so it's disabled but not because of the policy, it's a little bit weird but rn it's what we have

cy.login(user.username, password);
});

cy.visit(`/hosts/${selectedHost.agentId}/settings`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add Here we could have cy.contains('button', 'Start Execution').should('be.enabled');

@CDimonaco CDimonaco force-pushed the check_execution_policy_e2e branch from 7c54300 to 05bcb43 Compare July 4, 2024 10:37
@CDimonaco CDimonaco merged commit c383516 into main Jul 4, 2024
26 checks passed
@CDimonaco CDimonaco deleted the check_execution_policy_e2e branch July 4, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request test
Development

Successfully merging this pull request may close these issues.

2 participants