Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags abilities e2e tests #2747

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Tags abilities e2e tests #2747

merged 2 commits into from
Jul 8, 2024

Conversation

CDimonaco
Copy link
Member

Description

Tags abilities e2e testing

How was this tested?

Automated tests

@CDimonaco CDimonaco added javascript Pull requests that update Javascript code test labels Jul 4, 2024
@CDimonaco CDimonaco requested review from arbulu89 and EMaksy July 4, 2024 14:54
@CDimonaco CDimonaco self-assigned this Jul 4, 2024
Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good.
Take care of removing the its from the text please.

PD: I think we need to revisit a bit the code on disabled tags with @jagabomb
I saw now that we have only the cross of the existing tags with less opacity, which looks strange, in my head, when I commented it, the whole tag would go with less opacity, but this looks strange as well.

And besides that, now I check some code, the ExistingTag component name (which I proposed...) doesn't look really appropriate, as the component is the cross of the existing component, not the component itself. Maybe we should rename back to DeleteTagButton as you had at the beginning. I think I missunderstood what the code was doing, and thought that this was the whole tag itself, but is just the cross.

test/e2e/cypress/e2e/clusters_overview.cy.js Outdated Show resolved Hide resolved
test/e2e/cypress/e2e/clusters_overview.cy.js Outdated Show resolved Hide resolved
test/e2e/cypress/e2e/clusters_overview.cy.js Outdated Show resolved Hide resolved
@CDimonaco CDimonaco merged commit c930623 into main Jul 8, 2024
26 checks passed
@CDimonaco CDimonaco deleted the tags_policy_e2e branch July 8, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code test
Development

Successfully merging this pull request may close these issues.

2 participants