Activity Log settings e2e #2753
Conversation
balanza
force-pushed
the
actity-log-settings-e2e
branch
from
2f03212 to
4c09d30
Compare
| cy.get('@initialRetentionTime').then((text) => | ||
| section() | ||
| .get('[aria-label="retention-time"]') | ||
| .should('have.text', text) |
There was a problem hiding this comment.
how does this change from what we do in beforeEach? Are they both needed?
There was a problem hiding this comment.
In the beforeEach clause we read the initial text, here we ensure the test starts from there.
It's indeed a step that never fails, I mostly added it for completing the test case (start from a value x, get another value y). Should we remove it? I see no harm, I wonder if it can work as a "safety net" for regressions.
There was a problem hiding this comment.
No need to remove, just wanted to understand the rationale, and make sure it was not accidentally like that.
| @@ -677,4 +677,133 @@ context('Settings page', () => { | |||
| }); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('Activity log', () => { | |||
| // Elements must be filtered to match only the ones relate to the Activity Logs. | |||
There was a problem hiding this comment.
interesting approach.
Another way that I find helpful in order to get specific elements and avoid weird css selectors is using custom classes/labels/names (take a look at SUMA Credentials Management section)
No need to change anything, just wanting to share.
There was a problem hiding this comment.
First and foremost, I was experimenting thus I'm not sure my approach is good.
We have to face 2 orders of problems here:
- to select the element in the right section
- to select an element that might have been re-rendered.
Regarding 1, maybe selecting even cypress docs says that selecting by text is not a best practice (https://docs.cypress.io/guides/references/best-practices#Text-Content). Perhaps we can assign a specific class/ID to every section? Quirk: models don't fall under any section 🙃
I'm considering a refactor, though.
About 2, I found no other option than to use helper functions. I wonder if it's a huge burden for performance.
There was a problem hiding this comment.
Yes, I like that piece of document. I also find using highly brittle selectors that are subject to change (which is not the case here) a pain 🙈
All good from my side
balanza
dismissed
nelsonkopliku’s stale review
let's review your comments togheter
balanza
force-pushed
the
actity-log-settings-e2e
branch
from
124ad3d to
dc9b268
Compare
balanza
force-pushed
the
actity-log-settings-e2e
branch
from
dc9b268 to
7080165
Compare
balanza
force-pushed
the
actity-log-settings-e2e
branch
from
7080165 to
bb74f54
Compare
Description
Provide e2e tests for the Activity log section on the settings page.
This PR includes a refactor to the production code (eace365) that simplifies focusing on elements by segmenting the HTML with
<section>(no UI change is involved).