Discover angi architecture #2761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
added
enhancement
arbulu89
force-pushed
the
discover-angi-architecture
branch
from
08d67c8 to
2e7e789
Compare
CDimonaco
approved these changes
Jul 9, 2024
lib/trento/discovery/payloads/cluster/cluster_discovery_payload.ex
Outdated
Show resolved
Hide resolved
lib/trento/discovery/payloads/cluster/cluster_discovery_payload.ex
Outdated
Show resolved
Hide resolved
lib/trento/discovery/payloads/cluster/cluster_discovery_payload.ex
Outdated
Show resolved
Hide resolved
|
|
||
| # angi architecture follows a really similar configuration to the scale out one. | ||
| # That's why some functions are shared with classic scale out setup | ||
| defp parse_cluster_details( |
There was a problem hiding this comment.
Totally ok with the comment, the other option was to override any of the shared function, with the prefix angi and proxy them
There was a problem hiding this comment.
At the end, i was having already enough code duplication hehe
In any case, whoever looked for the proxy, would have the same questions, why angi is using scale out code XD
|
Hey @CDimonaco |
|
Damn, clicked wrong button XD |
arbulu89
force-pushed
the
discover-angi-architecture
branch
from
6d08c98 to
78d6bcb
Compare
CDimonaco
approved these changes
Jul 9, 2024
lib/trento/discovery/payloads/cluster/cluster_discovery_payload.ex
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Discovery of
angiarchitecture HANA clusters.A new field,
architecture_typehas been added to the hana cluster details, being "classic" and "angi" the possible values.The
architecture_typefield is now available in the clusters api.@abravosuse What do you think of the field name
architecture_type?How was this tested?
UT added