Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Affected packages #2763

Merged
merged 11 commits into from
Jul 11, 2024
Merged

Affected packages #2763

merged 11 commits into from
Jul 11, 2024

Conversation

janvhs
Copy link
Member

@janvhs janvhs commented Jul 9, 2024

Description

Display the affected packages and hosts (WIP) in the advisory details page.

How was this tested?

Elixir unit tests, Jest tests, Storybook

@janvhs janvhs added wip javascript Pull requests that update Javascript code elixir Pull requests that update Elixir code labels Jul 9, 2024
@janvhs
Copy link
Member Author

janvhs commented Jul 9, 2024

Would love to get your feedback, so I can copy paste it for the affected hosts section

Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some preliminary changes but in general good job, thank you for requesting feedback earlier!

assets/js/pages/AdvisoryDetails/AdvisoryDetails.test.jsx Outdated Show resolved Hide resolved
assets/js/lib/test-utils/factories/advisoryErrata.js Outdated Show resolved Hide resolved
assets/js/pages/AdvisoryDetails/AdvisoryDetails.jsx Outdated Show resolved Hide resolved
assets/js/lib/test-utils/factories/advisoryErrata.js Outdated Show resolved Hide resolved
@janvhs janvhs marked this pull request as ready for review July 11, 2024 08:54
janvhs added 11 commits July 11, 2024 10:55
This patch adds the affected packages to the advisory errata endpoint
and adds an openAPI spec for the changes.
This patch adds unit test cases and updates the existing cases to
include the new data available from the affected packages discovery.
This patch updates the AdvisoryDetails component to display the affected
packages.
…ckages

This patch updates and adds the frontend test and story to include the
affected packages data.
This patch adds the affected systems from the discovery result to the
errata details response. Therefore, this patch contains an update to
the openAPI specification. Furthermore, it adds new and updates
existing tests to include the changes.
This patch rewords the openAPI specification for the affected packages.
I changed the words, to clarify the difference between a package
version and a release.
This patch displays the systems affected by a advisory errata to the
user. It exposes the new backend API in the advisory errata page and
updates the relevant tests. This change required an update to the
factories.

Furthermore, I added a section for showcasing the "empty data" state in
the advisory details page.
@janvhs janvhs force-pushed the affected-packages branch from f40cd4f to ceebf41 Compare July 11, 2024 08:55
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janvhs janvhs merged commit 3610540 into main Jul 11, 2024
26 checks passed
@janvhs janvhs deleted the affected-packages branch July 11, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
elixir Pull requests that update Elixir code javascript Pull requests that update Javascript code wip
Development

Successfully merging this pull request may close these issues.

2 participants