-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Affected packages #2763
Affected packages #2763
Conversation
Would love to get your feedback, so I can copy paste it for the affected hosts section |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some preliminary changes but in general good job, thank you for requesting feedback earlier!
This patch adds the affected packages to the advisory errata endpoint and adds an openAPI spec for the changes.
This patch adds unit test cases and updates the existing cases to include the new data available from the affected packages discovery.
This patch updates the AdvisoryDetails component to display the affected packages.
…ckages This patch updates and adds the frontend test and story to include the affected packages data.
This patch adds the affected systems from the discovery result to the errata details response. Therefore, this patch contains an update to the openAPI specification. Furthermore, it adds new and updates existing tests to include the changes.
This patch rewords the openAPI specification for the affected packages. I changed the words, to clarify the difference between a package version and a release.
This patch displays the systems affected by a advisory errata to the user. It exposes the new backend API in the advisory errata page and updates the relevant tests. This change required an update to the factories. Furthermore, I added a section for showcasing the "empty data" state in the advisory details page.
f40cd4f
to
ceebf41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Display the affected packages and hosts (WIP) in the advisory details page.
How was this tested?
Elixir unit tests, Jest tests, Storybook