Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e test for settings view to test abilities/permissions #2772

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

EMaksy
Copy link
Member

@EMaksy EMaksy commented Jul 12, 2024

Description

This pr i a follow up pr to #2760.
Adding cypress e2e test to do what:

  • Test if a user has no abilities/permissions the settings view has disabled buttons (all besides test connection button)
  • Test if a user has proper abilities/permissions the settings buttons are enabled
  • Fix a missed only

Did you add the right label?

  • DONE

How was this tested?

Added missing cypress e2e test for settings view.
Tests were already done in previous pr

  • DONE

Did you update the documentation?

No docs update required

  • DONE

@EMaksy EMaksy self-assigned this Jul 12, 2024
@EMaksy EMaksy added enhancement New feature or request javascript Pull requests that update Javascript code test labels Jul 12, 2024
@EMaksy EMaksy force-pushed the update_e2e_settings_page_for_new_policies branch from 89bbdc1 to 4aba0ae Compare July 12, 2024 09:20
@CDimonaco CDimonaco self-requested a review July 12, 2024 09:20
@EMaksy EMaksy marked this pull request as ready for review July 12, 2024 09:36
@EMaksy EMaksy changed the title Add e2e test for settings view WIP Add e2e test for settings view to test abilities/permissions Jul 12, 2024
@EMaksy EMaksy force-pushed the update_e2e_settings_page_for_new_policies branch from 4aba0ae to 9a501d6 Compare July 12, 2024 10:56
@EMaksy EMaksy requested a review from arbulu89 July 12, 2024 14:35
Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @EMaksy
LGTM

test/e2e/cypress/e2e/settings.cy.js Show resolved Hide resolved
test/e2e/cypress/e2e/settings.cy.js Outdated Show resolved Hide resolved
test/e2e/cypress/e2e/settings.cy.js Show resolved Hide resolved
test/e2e/cypress/e2e/settings.cy.js Outdated Show resolved Hide resolved
@EMaksy EMaksy force-pushed the update_e2e_settings_page_for_new_policies branch 2 times, most recently from 54dabab to d5c4c3b Compare July 15, 2024 09:49
@EMaksy EMaksy force-pushed the update_e2e_settings_page_for_new_policies branch from d5c4c3b to 98bb88e Compare July 15, 2024 09:56
@EMaksy EMaksy force-pushed the update_e2e_settings_page_for_new_policies branch from 98bb88e to 91941f8 Compare July 15, 2024 11:51
@EMaksy EMaksy merged commit 69097be into main Jul 15, 2024
26 checks passed
@EMaksy EMaksy deleted the update_e2e_settings_page_for_new_policies branch July 15, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request javascript Pull requests that update Javascript code test
Development

Successfully merging this pull request may close these issues.

3 participants