Fix flickering in Available Software Updates panel
#2789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamie-suse
added
bug
jamie-suse
changed the title
Available Software Updates panelAvailable Software Updates panel
dottorblaster
approved these changes
Jul 17, 2024
Comment on lines
20
to
26
| def call(conn, {:error, :suma_authentication_error}) do | ||
| conn | ||
| |> put_status(:forbidden) | ||
| |> put_view(ErrorView) | ||
| |> render(:"403", reason: "SUSE Manager authentication error.") | ||
| end | ||
|
|
There was a problem hiding this comment.
Since we now rely on 403 for our own permissions system it's better to switch this to 404 or 422, no big deal
jamie-suse
commented
Jul 17, 2024
| ({ detail }) => detail === 'SUSE Manager authentication error.' | ||
| ); | ||
|
|
||
| if (errorCode === 422 && suma_unauthorized) { |
There was a problem hiding this comment.
I check the status code here for completeness, though technically we may not need to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue in the UI where the Available Software Updates panel was rendering two different loading states at two different times. The result of this was that the users were seeing a flicker as the panel (briefly) moved into a loading state a second time. This created a confusing user experience.
See the image below for the typical sequence of Redux events that would happen during rendering:
Note how the panel enters a loading state while retrieving the software updates, the response returns and the software updates are saved. Much later however the network call to retrieve the SUSE Manager settings begins, and sets the second loading state. The settings are then returned, and the panel is set into the display state again. This is a confusing user experience.
This was fixed by removing the superfluous call to retrieve the SUSE Manager settings, as they are not actually relevant to the Host Details page, nor the Available Software Updates panel. Since we know that if we can retrieve the software updates, then obviously the settings are configured correctly. To emphasize; we don't care about the specific SUSE Manager settings, just if we are authorized to access SUSE Manager with our settings.
We differentiate between being unauthorized vs some other network or server error by returning a
422status code and corresponding error message"SUSE Manager authentication error."in the response from Trento's SUSE Manager Controller. The frontend can then know that the SUSE Manager settings are not configured correctly and displays the SUSE Manager is not configured state to the user.How was this tested?
Units tests updated.
Did you update the documentation?
No changes are required for the documentation.