Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cypress E2E Tests parallelization #3208
base: main
Are you sure you want to change the base?
Cypress E2E Tests parallelization #3208
Changes from 27 commits
246d0b3
d8d8ccd
8ddc6f1
0efd1d4
00b728c
11dc3ce
d596413
96789ab
42d88c6
dbfcb09
4f14c66
e1d2864
9bd31ad
c7b3290
441e1d9
14ad1c9
f432f7e
ce9e2b9
a9f3c36
7288119
0c50871
73b76c9
8383884
7034908
15b9b64
53c173e
796bb36
530fed5
a5993d4
7b45b21
c472819
0ebcfac
fd242bd
a281e3d
bc92f77
55bd49b
77166ea
ca3bfae
43f967c
09a331d
72c817d
1075ea7
4473d68
7e8446a
40b91b0
fb6973d
acd7891
a5d06dc
d506731
7016a06
a587242
93b1bb8
7d51683
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: Do you think we can better understand why it is needed, to remove it?
Sleeps on arbitrary time spans are often cause of flakiness, as they may depend on the running machine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a fan of arbitrary waits either and I know they should be avoided as a good practice, for the moment I don't have a conclusive answer tbh but I noticed that with a bit of delay the hosts_overview test flakiness is reduced a lot so I added it as a contingency measure, we can remove it if you want or even we can try the test flakiness tool designed by @gagandeepb then try with and without the arbitrary sleep and compare results.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have an alternative so I guess I must live with it 🤷♂️