Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hana scale up scenario as selection in checks catalog #3210

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

EMaksy
Copy link
Member

@EMaksy EMaksy commented Dec 20, 2024

Description

This pr enriches the checks catalog view by changing the Hana Scale Up filter to Perf Opt and adding a new filter with cost optimized scenario.

Demo before PR

image

Demo after PR

image

New features:

  • Rename "HANA Scale Up" as "HANA Scale Up Perf. Opt." in Cluster Types filter in Checks Catalog view
    when selected, checks applicable to "HANA Scale Up Perf. Opt." clusters will be displayed in the view
  • Add "HANA Scale Up Cost Opt." in Cluster Types filter in Checks Catalog view
    when selected, checks applicable to "HANA Scale Up Cost Opt." clusters will be displayed in the view
    Fixes # (issue)

How was this tested?

  • Fixed existing tests

@EMaksy EMaksy added enhancement New feature or request javascript Pull requests that update Javascript code env Create an ephimeral environment for the pr branch labels Dec 20, 2024
@EMaksy EMaksy self-assigned this Dec 20, 2024
@EMaksy
Copy link
Member Author

EMaksy commented Dec 20, 2024

The implementation request was not to add another filter selection but to enrich the existing implementation we have. This opened some technical challenges, how to make it work. Overall the filtering could use a overall refactoring.
Maybe there are other alternatives to my approach.
@arbulu89 what do you think ?

@EMaksy EMaksy removed the env Create an ephimeral environment for the pr branch label Dec 20, 2024
@EMaksy EMaksy requested a review from arbulu89 December 20, 2024 13:10
@EMaksy EMaksy added the env Create an ephimeral environment for the pr branch label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request env Create an ephimeral environment for the pr branch javascript Pull requests that update Javascript code
Development

Successfully merging this pull request may close these issues.

1 participant