Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the collapsable sidebar #344

Merged
merged 2 commits into from
Apr 13, 2022
Merged

Implement the collapsable sidebar #344

merged 2 commits into from
Apr 13, 2022

Conversation

arbulu89
Copy link
Contributor

Collapsable sidebar. It is more minimalist than the old trento, but it looks pretty nice, and it uses the default logic of tailwind:
collapsable-sidebar

Copy link
Contributor

@rtorrero rtorrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, just pay attention to a couple comments 👍

assets/js/components/Layout/Layout.jsx Outdated Show resolved Hide resolved
assets/js/components/Layout/Layout.jsx Outdated Show resolved Hide resolved
@arbulu89 arbulu89 force-pushed the collapsable-sidebar branch from 374ff03 to c5c6749 Compare April 13, 2022 08:48
@arbulu89 arbulu89 requested a review from dottorblaster April 13, 2022 08:48
@arbulu89
Copy link
Contributor Author

@dottorblaster Changes done

Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arbulu89 arbulu89 merged commit a075f67 into main Apr 13, 2022
@arbulu89 arbulu89 deleted the collapsable-sidebar branch April 13, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants