Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix alerts event handler ArgumentError when disabled #454

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Fix alerts event handler ArgumentError when disabled #454

merged 1 commit into from
Apr 28, 2022

Conversation

fabriziosestito
Copy link
Member

🔢

@fabriziosestito fabriziosestito force-pushed the fix_alerts_event_handler branch from 61ed668 to 621c697 Compare April 27, 2022 15:58
arbulu89
arbulu89 approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
I can run it in my deployment to confirm if it fixes the issue, if you want, before merging.
Let me know

@fabriziosestito
Copy link
Member Author

Looks good! I can run it in my deployment to confirm if it fixes the issue, if you want, before merging. Let me know

@arbulu89 sure! thanks!

@arbulu89
Copy link
Contributor

@fabriziosestito Tested. I don't see that error message any more!

1 similar comment
@arbulu89
Copy link
Contributor

@fabriziosestito Tested. I don't see that error message any more!

@arbulu89 arbulu89 merged commit e8aae5f into main Apr 28, 2022
@arbulu89 arbulu89 deleted the fix_alerts_event_handler branch April 28, 2022 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arbulu89 arbulu89 arbulu89 approved these changes

@nelsonkopliku nelsonkopliku Awaiting requested review from nelsonkopliku

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabriziosestito @arbulu89