Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NavLink in the navigation elements #623

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Use NavLink in the navigation elements #623

merged 1 commit into from
Jun 7, 2022

Conversation

arbulu89
Copy link
Contributor

@arbulu89 arbulu89 commented Jun 2, 2022 •
edited
Loading

Use NavLink in the navigation elements to highlight the children elements. For example:

image

When we are in the cluster details page (before this change, it sidebar entry wouldn't be highlighted as active).

Find more info about NavLink in: https://www.geeksforgeeks.org/link-and-navlink-components-in-react-router-dom/

A is a special kind of that knows whether or not it is “active”. Now, let’s understand this with the help of an example.

I have included a couple of tests in the host entries.

@arbulu89 arbulu89 added the bug Something isn't working label Jun 2, 2022
nelsonkopliku
nelsonkopliku approved these changes Jun 6, 2022
View reviewed changes
Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, thanks! 🚀

dottorblaster
dottorblaster approved these changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arbulu89 arbulu89 merged commit f6aaab2 into main Jun 7, 2022
@arbulu89 arbulu89 deleted the nav-is-active branch June 7, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsonkopliku nelsonkopliku nelsonkopliku approved these changes

@dottorblaster dottorblaster dottorblaster approved these changes

@fabriziosestito fabriziosestito Awaiting requested review from fabriziosestito

@rtorrero rtorrero Awaiting requested review from rtorrero

@stefanotorresi stefanotorresi Awaiting requested review from stefanotorresi

Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arbulu89 @dottorblaster @nelsonkopliku