Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display aws metadata frontend #650

Merged
merged 4 commits into from
Jun 10, 2022
Merged

Display aws metadata frontend #650

merged 4 commits into from
Jun 10, 2022

Conversation

arbulu89
Copy link
Contributor

Display AWS cloud details. Besides this:

  • Rename Cloud details to Provider details
  • Handle the unknown scenario with a Provider not recognized message

@abravosuse Putting you as reviewer simply you can validation the images and the visualized data hehe

This is how it looks like:

AWS:
image

Unknown:
image

If the Pill option is not good, we could use a simpler one (or any other suggestion):
image

@arbulu89 arbulu89 added the enhancement New feature or request label Jun 10, 2022
dottorblaster
dottorblaster approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! One tiny comment and we are done I think 👍

assets/js/components/HostDetails/ProviderDetails.jsx Outdated Show resolved Hide resolved
nelsonkopliku
nelsonkopliku approved these changes Jun 10, 2022
View reviewed changes
Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rtorrero
rtorrero approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@rtorrero rtorrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pills option for the unknown cloud provider looks good to me.

GJ

assets/js/components/HostDetails/AwsDetails.jsx Outdated Show resolved Hide resolved
assets/js/components/HostDetails/AwsDetails.jsx Outdated Show resolved Hide resolved
abravosuse
abravosuse approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@abravosuse abravosuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pill option looks good to me.

@arbulu89 arbulu89 force-pushed the display-aws-metadata-frontend branch from da25619 to 6285f8c Compare June 10, 2022 13:39
@arbulu89 arbulu89 force-pushed the display-aws-metadata-frontend branch from 6285f8c to a088615 Compare June 10, 2022 13:40
@arbulu89 arbulu89 merged commit af1983a into main Jun 10, 2022
@arbulu89 arbulu89 deleted the display-aws-metadata-frontend branch June 10, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abravosuse abravosuse abravosuse approved these changes

@nelsonkopliku nelsonkopliku nelsonkopliku approved these changes

@rtorrero rtorrero rtorrero approved these changes

@dottorblaster dottorblaster dottorblaster approved these changes

@fabriziosestito fabriziosestito Awaiting requested review from fabriziosestito

@stefanotorresi stefanotorresi Awaiting requested review from stefanotorresi

Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@arbulu89 @dottorblaster @rtorrero @nelsonkopliku @abravosuse