Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display gcp metadata frontend #662

Merged
merged 2 commits into from
Jun 14, 2022
Merged

Display gcp metadata frontend #662

merged 2 commits into from
Jun 14, 2022

Conversation

arbulu89
Copy link
Contributor

Last piece of the puzzle to show the GCP details in the frontend:

image

@arbulu89 arbulu89 added the enhancement New feature or request label Jun 14, 2022
abravosuse
abravosuse approved these changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@abravosuse abravosuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code aside, LGTM.

nelsonkopliku
nelsonkopliku approved these changes Jun 14, 2022
View reviewed changes
Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

stefanotorresi
stefanotorresi approved these changes Jun 14, 2022
View reviewed changes
Copy link
Member

@stefanotorresi stefanotorresi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noiice!

@arbulu89 arbulu89 merged commit 9ad96fa into main Jun 14, 2022
@arbulu89 arbulu89 deleted the display-gcp-metadata-frontend branch June 14, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abravosuse abravosuse abravosuse approved these changes

@nelsonkopliku nelsonkopliku nelsonkopliku approved these changes

@stefanotorresi stefanotorresi stefanotorresi approved these changes

@dottorblaster dottorblaster Awaiting requested review from dottorblaster

@fabriziosestito fabriziosestito Awaiting requested review from fabriziosestito

@rtorrero rtorrero Awaiting requested review from rtorrero

Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arbulu89 @stefanotorresi @nelsonkopliku @abravosuse