Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons to health status indicators #677

Merged
merged 2 commits into from
Jun 21, 2022

Conversation

rtorrero
Copy link
Contributor

This PR improves the health status indicators in multiple views by including an icon for additional feedback when either passing, warning or critical.

Example:
new-health-indicators

This is specially useful for people suffering from color blindness

Copy link
Contributor

@abravosuse abravosuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments/questions, @rtorrero

  1. The warning sign will be a yellow triangle with white background and an exclamation mark inside, right?
  2. This applies to all views across the console, not just the dashboard, correct?

Thx!

Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
As @abravosuse said, please check if all the health icons all around the app are using this HealthIcon.

Besides that, only a leftover import I think

assets/js/components/Health/HealthIcon.jsx Outdated Show resolved Hide resolved
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you can try writing a jest test for this too if you feel about it

@rtorrero rtorrero force-pushed the improve-health-colors-accessibility branch from a205a65 to 462d668 Compare June 21, 2022 13:30
@rtorrero
Copy link
Contributor Author

rtorrero commented Jun 21, 2022

Two comments/questions, @rtorrero

1. The warning sign will be a yellow triangle with white background and an exclamation mark inside, right?

2. This applies to all views across the console, not just the dashboard, correct?

Thx!

Yes, I checked all other views and can confirm that both the warning message works and that the change affects all views. Only the hosts lists was manually setting the health indicators without the component and that was already changed in the PR

Just to share how the warning icon looks like:
works

@rtorrero
Copy link
Contributor Author

@dottorblaster Added the Jest test, thanks for the suggestion 👌

@rtorrero rtorrero force-pushed the improve-health-colors-accessibility branch from 902ee8f to 8d1f12c Compare June 21, 2022 14:47
@rtorrero rtorrero merged commit e9ff3c5 into main Jun 21, 2022
@rtorrero rtorrero deleted the improve-health-colors-accessibility branch June 21, 2022 15:01
@arbulu89 arbulu89 added the enhancement New feature or request label Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

4 participants