Highlight check result row on hover and id in green #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottorblaster
approved these changes
Jul 27, 2022
There was a problem hiding this comment.
If the background color looks good to @jagabomb then LGTM 😄
|
This looks good to me and I agree with @arbulu89 point of standardising all clickable rows in the ui to this styling. But before you do I just want to check it out in a few design mockups first before you action this as a global change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The colors are coming from https://tailwindcss.com/docs/background-color
@jagabomb Feel free to recommend other color set.
Edit: @dottorblaster @jagabomb I was actually thinking if all "clickable" rows in our app (check results, catalog, sap system/hana database expandable rows, etc) should follow the same styling