Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed restart strategy from docker-compose file #926

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

CDimonaco
Copy link
Member

Description

As stated in the title, we need that in order to clean and not bloat the docker containers in development.
We've done that refactor in other projects.

How was this tested?

Manually

Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but e2e tests are failing 🤔 related?

@CDimonaco
Copy link
Member Author

Looks good, but e2e tests are failing thinking related?

nope 👀

Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CDimonaco CDimonaco merged commit 9db0f2d into main Oct 21, 2022
@CDimonaco CDimonaco deleted the docker_compose_restart_strategy_refactor branch October 21, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants