Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use uuid format for id fields #949

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Use uuid format for id fields #949

merged 1 commit into from
Nov 3, 2022

Conversation

arbulu89
Copy link
Contributor

@arbulu89 arbulu89 commented Nov 3, 2022

Description

Use uuid format for cluster, host, sap system ids in the domain events/commands/aggregates

How was this tested?

Tests were alright

@arbulu89 arbulu89 marked this pull request as ready for review November 3, 2022 12:00
CDimonaco
CDimonaco approved these changes Nov 3, 2022
View reviewed changes
Copy link
Member

@CDimonaco CDimonaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fabriziosestito fabriziosestito merged commit 2446e4c into main Nov 3, 2022
@fabriziosestito fabriziosestito deleted the uuid-for-ids branch November 3, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CDimonaco CDimonaco CDimonaco approved these changes

@fabriziosestito fabriziosestito fabriziosestito approved these changes

@dottorblaster dottorblaster Awaiting requested review from dottorblaster

@rtorrero rtorrero Awaiting requested review from rtorrero

@nelsonkopliku nelsonkopliku Awaiting requested review from nelsonkopliku

Assignees
No one assigned
Labels
chore tech debt
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arbulu89 @fabriziosestito @CDimonaco