Enable box health filters on Dashboard #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Rubén Torrero Marijnissen <rtorreromarijnissen@suse.com>
CDimonaco
changed the title
|
Code apart, it looks good to me. |
jagabomb
approved these changes
Nov 4, 2022
arbulu89
reviewed
Nov 4, 2022
|
@CDimonaco Can we also add the highlighted hover states for the Health Filter buttons? The hover states are visible in the initial prototype link. |
rtorrero
reviewed
Nov 4, 2022
|
Yesterday was a little bit hard we skipped tests, but test and hover state are incoming, stay tuned 👀 |
|
@jagabomb There are the on hover animations when the boxes are selected |
|
Tests added with jest. I also removed old e2e tests for the home dashboard which are now covered in the jest testing files |
loving this mega thumbs up |
CDimonaco
force-pushed
the
dashboard_home_filters_overview
branch
from
a2ae98c to
127efa5
Compare
CDimonaco
force-pushed
the
dashboard_home_filters_overview
branch
from
fd41a3c to
99b52ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Rubén Torrero Marijnissen rtorreromarijnissen@suse.com
Description
Health Filters in dashboard views
How was this tested?
Manually.