Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SAP Instances status icon interactive #961

Merged
merged 3 commits into from
Nov 8, 2022
Merged

Conversation

EMaksy
Copy link
Member

@EMaksy EMaksy commented Nov 7, 2022

Description

When the user clicks on the SAP instances status icon in the Dashboard, it takes him to the corresponding "SAP System Details" view.

Updated documentation of "Interface SapSystemHealthSummary" to list all the used key value pairs in the current item object
and fixed naming for factories.

How was this tested?

Added a frontend test for automated testing

@EMaksy EMaksy added enhancement New feature or request javascript Pull requests that update Javascript code test labels Nov 7, 2022
@EMaksy EMaksy requested a review from dottorblaster November 7, 2022 15:50
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assets/js/components/HealthSummary/HomeHealthSummary.jsx Outdated Show resolved Hide resolved
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EMaksy EMaksy merged commit 8d46ff7 into trento-project:main Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request javascript Pull requests that update Javascript code test
Development

Successfully merging this pull request may close these issues.

2 participants