Improve catalog container usability #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
requested review from
dottorblaster,
fabriziosestito,
rtorrero,
nelsonkopliku and
CDimonaco
arbulu89
force-pushed
the
improve-catalog-container-usability
branch
from
76881e5 to
5231fd9
Compare
dottorblaster
requested changes
Nov 24, 2022
assets/js/state/catalog_new.js
Outdated
| const initialState = { | ||
| loading: true, | ||
| data: [], | ||
| error: null, |
There was a problem hiding this comment.
I'd like to have error: true|false and errorMessage, what do you think?
arbulu89
force-pushed
the
improve-catalog-container-usability
branch
from
f49efac to
600f3e9
Compare
|
Hey @dottorblaster , |
arbulu89
force-pushed
the
improve-catalog-container-usability
branch
from
600f3e9 to
d35fd4f
Compare
dottorblaster
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the
CatalogContainerusage a bit more generic. This will help us to reuse this component in other places where the catalog data is queried from wanda.In order to achieve that, I have added a new reducer, selector and saga combo. This helps on testing side as well.
How was this tested?
Reducers, selectors and sagas tests added. In order to test the latest one, I have added the
axios-mock-adapterto mock the api calls.Here some references on how to test redux code (official docs):
https://redux.js.org/usage/writing-tests
https://redux-saga.js.org/docs/advanced/Testing/