Remove scroll from body when modal is open #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
This uses a bit of a hacky workaround to do this. We set a value on the $rootScope that the base template can then use to change a class on the body. In a future version of angular bootstrap they are supposed to add back in a way to do this automatically as part of that tool.
| $rootScope.modalIsUp = true; | ||
| $modal.open(opts).finally(function() { | ||
| $rootScope.modalIsUp = true; | ||
| }); |
There was a problem hiding this comment.
doesn't one of these need to set the value to false?
There was a problem hiding this comment.
Yes, the one in the infally should set to false. Missed that one.
my8bird
added a commit
that referenced
this pull request
Sep 16, 2013
Remove scroll from body when modal is open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add .no-scroll to body on modal open
Remove .no-scroll from body on modal close