[DOCS] Improve document in reflection (apache#5593)

trevor-m · Jun 18, 2020 · 12d427b · 12d427b
1 parent f6c2804
commit 12d427b
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/apps/cpp_rpc/README.md b/apps/cpp_rpc/README.md
@@ -39,7 +39,7 @@ This folder contains a simple recipe to make RPC server in c++.
 - Build tvm with the argument -DUSE_CPP_RPC
 - Install [LLVM pre-build binaries](https://releases.llvm.org/download.html), making sure to select the option to add it to the PATH.
 - Verify Python 3.6 or newer is installed and in the PATH.
-- Use `<tmv_output_dir>\tvm_rpc.exe` to start the RPC server
+- Use `<tvm_output_dir>\tvm_rpc.exe` to start the RPC server
 
 ## How it works
 - The tvm runtime dll is linked along with this executable and when the RPC server starts it will load the tvm runtime library.
@@ -59,4 +59,4 @@ Command line usage
 ```
 
 ## Note
-Currently support is only there for Linux / Android / Windows environment and proxy mode doesn't be supported currently.
+Currently support is only there for Linux / Android / Windows environment and proxy mode doesn't be supported currently.
diff --git a/apps/extension/python/tvm_ext/__init__.py b/apps/extension/python/tvm_ext/__init__.py
@@ -58,7 +58,7 @@ def __getitem__(self, idx):
 class NDSubClass(tvm.nd.NDArrayBase):
     """Example for subclassing TVM's NDArray infrastructure.
 
-    By inheriting TMV's NDArray, external libraries could
+    By inheriting TVM's NDArray, external libraries could
     leverage TVM's FFI without any modification.
     """
 

diff --git a/include/tvm/node/reflection.h b/include/tvm/node/reflection.h
@@ -225,7 +225,11 @@ class ReflectionVTable::Registry {
  *  // Example SEQualReduce traits for runtime StringObj.
  *
  *  struct StringObjTrait {
- *     static constexpr const std::nullptr_t VisitAttrs = nullptr;
+ *    static constexpr const std::nullptr_t VisitAttrs = nullptr;
+ *
+ *    static void SHashReduce(const runtime::StringObj* key, SHashReducer hash_reduce) {
+ *      hash_reduce->SHashReduceHashedValue(runtime::String::HashBytes(key->data, key->size));
+ *    }
  *
  *    static bool SEqualReduce(const runtime::StringObj* lhs,
  *                             const runtime::StringObj* rhs,