-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A Congratulations you won text box? #33
Comments
If you checkmate your opponent (offline or online) it should immediately notify you of the checkmate, and end the game. If that didn't happen it sounds like there could be a bug. I'd be interested in seeing the logs if you still have them around. The various log files can be found here: |
I believe I did you take back in this game to see how it would work. I may have us |
The base model update method was being called before we report the game has ended. This caused a delay in reporting of the game over status.
I've released a new version of cli-chess (v1.4.2) which from my testing addresses this issue. It also adds additional logging which should make root cause discovery next time a little quicker. Feel free to try out the new version and open a bug report if you run into this again, or any other issues! Also, I saw in the logs you attempted to type As far as producing a PGN at the end of the game, it's been requested (#19) and I'd happily review any PR that comes across for it! I'm closing this enhancement as you should always see a proper game over message when a game completes. Hopefully the changes in v1.4.2 actually make that happen for you now! |
What feature would you like to see in cli-chess?
I won and it was great in Offline mode. But then it still prompted me for a move and the only way to exit was to type quit and then it pronounced the checkmated white side victorious. ;/
The text was updated successfully, but these errors were encountered: