Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom httpx proxy and user_agent for Scraper #220

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

cr4kn4x
Copy link

@cr4kn4x cr4kn4x commented May 22, 2024

Added support for optional usage of proxies and custom user-agents that can be passed in the construction of the Scraper Class. If the options are not provided, the Scraper class will use the random user agent and no proxy.

Copy link

@Joeymonkey29 Joeymonkey29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bull shit need my page back

@cr4kn4x cr4kn4x closed this May 28, 2024
@zxj0302
Copy link

zxj0302 commented May 28, 2024

Bull shit need my page back

? What do you mean? I think this version is great and works well.

@zxj0302
Copy link

zxj0302 commented May 28, 2024

@cr4kn4x Hi, why close?

@cr4kn4x
Copy link
Author

cr4kn4x commented May 28, 2024

@cr4kn4x Hi, why close?

I can reopen again, but I think it won't get merged in near future. Seems like the maintainer is currently inactive

@cr4kn4x cr4kn4x reopened this May 28, 2024
@zxj0302
Copy link

zxj0302 commented May 28, 2024

@cr4kn4x Yes the maintainer seems not so active recently. However, your pr is great ❤️ and I am very appreciated for your work since the proxy is a must if we don't have large number of accounts and want to scrape in bulk.

Thanks again and I think this proxy function will help lots of users(pls don't get upset/blue just because someone's remark, I back you up ❤️ ). 👍

@trevorhobenshield
Copy link
Owner

if we don't have large number of accounts and want to scrape in bulk

unfortunately proxies will not help in this case, as most of Twitter's rate limits are not determined by IP

i appreciate the effort on this PR, it's a great start. however, there are quite a few things to take into consideration. for example, users who want to access the onion site cannot do so, as httpx doesn't support socks5h. i'll come up with a list of requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants