Updated to work with Puppet 4.10 and later #3
Conversation
jeannegreulich
commented
Mar 19, 2019
jeannegreulich
commented
- Updated code to use strong types and removed deprecated functions
- Updated Gemfile and metadata.json to use later supported versions of puppet
- Updated the tests to use later version of beaker
- Added centos 7 to acceptance tests
jeannegreulich
force-pushed
the
updateversions
branch
8 times, most recently
from
c853c7f to
82674bb
Compare
jeannegreulich
force-pushed
the
updateversions
branch
from
82674bb to
d7976a6
Compare
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "treydock-kdump", | |||
| "version": "0.0.1", | |||
| "version": "0.1.0", | |||
There was a problem hiding this comment.
Because dropping Puppet 3 should probably go ahead and make this 1.0.0. Noticed voxpupuli tends to bump major version when dropping support for versions of Puppet and I've been following same pattern with other modules.
There was a problem hiding this comment.
Technically, pre 1.0.0, semver says you can do what you like.
Major version zero (0.y.z) is for initial development. Anything may change at any time. The public API should not be considered stable.
There was a problem hiding this comment.
Good point, in that case 0.1.0 is fine.
There was a problem hiding this comment.
I left the version 0.1.0. I will leave it up to you guys to set the version as you see fit. If you want to pass the 1.0.0 threshhold that makes sense to me but I think it should be the owners choice.
|
Isn't Puppet 4 EOL? Unless your still using I'd suggest making supported Puppet just be 5 and 6. |
because puppet 4 is on its way out but still suppoerted by some. - Set upper bound for stdlib to 6.0.
|
I fixed the upper version for stdlib. I made the travis test for 4.10 allow failures but we still (for the time being) support 4.10. |
|
Released for forge as 0.1.0 |
