Do not sort spank plugin arguments

treydock · Jan 26, 2021 · 75531a7 · 75531a7
1 parent 67673a9
commit 75531a7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/spec/defines/slurm_spank_spec.rb b/spec/defines/slurm_spank_spec.rb
@@ -51,7 +51,7 @@
 
  it do
  verify_fragment_contents(catalogue, 'plugstack.conf-x11', [
- 'optional x11.so helpertask_cmd=2>/tmp/log ssh_cmd=ssh',
+ 'optional x11.so ssh_cmd=ssh helpertask_cmd=2>/tmp/log',
  ])
  end
  end
@@ -61,7 +61,7 @@
 
  it do
  verify_fragment_contents(catalogue, 'plugstack.conf-x11', [
- 'optional x11.so helpertask_cmd=2>/tmp/log ssh_cmd=ssh',
+ 'optional x11.so ssh_cmd=ssh helpertask_cmd=2>/tmp/log',
  ])
  end
  end

diff --git a/templates/spank/plugin.conf.erb b/templates/spank/plugin.conf.erb
@@ -4,11 +4,11 @@ values << (@required ? "required" : "optional")
 values << @plugin
 case @arguments
 when Hash
- @arguments.keys.sort.each do |k|
- values << "#{k}=#{@arguments[k]}"
+ @arguments.each_pair do |k,v|
+ values << "#{k}=#{v}"
  end
 when Array
- @arguments.sort.each do |a|
+ @arguments.each do |a|
  values << a
  end
 when String