Allow configuring munge via this module

[martijndegouw]

No description provided.

[treydock]

This would cause conflicts and duplicate resource issues for anyone who specifies include munge before including the SLURM module or anyone who uses class { 'munge': ... } inside a profile. One way I've made these kind of include vs class declaration choices in modules is allow a site to change the behavior with a parameter. So I'd recommend something like this:

Boolean $manage_munge_class = false

Then inside the new slurm::common::munge do this:

if $slurm::manage_munge_class {
  class { 'munge':
   ...
   }
} else {
  include munge
}

Also you will need to update slurmd.pp, slurmdbd.pp and slurmctld.pp to use the new common munge class rather than direct munge include.

[martijndegouw]

Thanks a lot for the feedback. I updated the PR accordingly.

[treydock]

These 3 new parameters will need documentation at the top of the file otherwise the puppet-lint tests will fail.

[treydock]

Suggested change

	# @manage_munge
	# @munge_key_source
	# @munge_key_content
	# @param manage_munge
	# @param munge_key_source
	# @param munge_key_content

[martijndegouw]

aaaaaaaaargh

[martijndegouw]

It must be friday...

[treydock]

Go ahead and merge master branch or rebase against master to pick up fix for acceptance tests.