Deploy topology.conf unconditionally #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As mentioned in #52, this is the change I made locally to get srun working. I'm happy to revise the approach and add a new path through the previous conditional statement, if preferred. |
|
Left comment on #52 before I saw PR. This approach is fine, as it's essentially the same end result. |
treydock
reviewed
Jan 25, 2024
treydock
reviewed
Jan 25, 2024
optiz0r
force-pushed
the
52_topology
branch
2 times, most recently
from
2f3c27f
to
d4268d7
Compare
|
Some unit tests are failing due to lint issues with trailing commas in the unit tests. |
|
I'll take a closer look, I was fighting vscode trying to make excessive changes with formatting. Bear with me. |
srun will fail if slurm.conf defines use of a topology plugin but topology.conf does not exist on login nodes. Previously, topology.conf was only deployed to slurmd and slurmctld nodes. ``` $ srun -c 1 -n 1 --mem 1g --pty bash srun: error: s_p_parse_file: cannot stat file /etc/slurm/topology.conf: No such file or directory, retrying in 1sec up to 60sec srun: fatal: something wrong with opening/reading /etc/slurm/topology.conf: No such file or directory ``` This change removes the conditional and deploys topology.conf to all nodes. Fixes treydock#52
treydock
reviewed
Feb 14, 2024
|
This is released with v3.1.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
srun will fail if slurm.conf defines use of a topology plugin but topology.conf does not exist on login nodes. Previously, topology.conf was only deployed to slurmd and slurmctld nodes.
This change removes the conditional and deploys topology.conf to all nodes.
Fixes #52