Fix slurm::spank when managing package and using configless

manifests/spank.pp

@@ -31,20 +31,23 @@
  }
 
  if $manage_package {
+ $fragment_require = Package["SLURM SPANK ${name} package"]
  package { "SLURM SPANK ${name} package":
  ensure => 'installed',
  name => $package_name,
- before => Concat::Fragment["plugstack.conf-${name}"],
- notify => $slurm::slurmd_notify,
+ notify => $slurm::service_notify,
  require => $package_require,
  }
+ } else {
+ $fragment_require = undef
  }
 
  if $slurm::manage_slurm_conf and ! $slurm::configless {
  concat::fragment { "plugstack.conf-${name}":
  target => 'plugstack.conf',
  content => template('slurm/spank/plugin.conf.erb'),
  order => $order,
+ require => $fragment_require,
  }
  }
 

spec/defines/slurm_spank_spec.rb

@@ -18,14 +18,15 @@
  it do
  is_expected.to contain_package('SLURM SPANK x11 package').only_with(ensure: 'installed',
  name: 'slurm-spank-x11',
- before: 'Concat::Fragment[plugstack.conf-x11]')
+ notify: [])
  end
 
  it do
  is_expected.to contain_concat__fragment('plugstack.conf-x11').only_with(
  target: 'plugstack.conf',
  content: %r{^optional x11.so$},
  order: '50',
+ require: 'Package[SLURM SPANK x11 package]',
  )
  end
 
@@ -75,6 +76,14 @@
  end
  end
 
+ describe 'configless' do
+ let(:pre_condition) { "class { 'slurm': slurmd => true, configless => true }" }
+
+ it 'works without error' do
+ is_expected.to create_slurm__spank('x11')
+ end
+ end
+
  describe 'auks example' do
  let(:title) { 'auks' }
  let(:params) do