Race condition in node

[mroz22]

When I run a method with invalid params in node environemnt.

It goes here:

connect/src/js/core/Core.js

Line 272 in b945218

postMessage(new ResponseMessage(responseID, false, { error: ERROR.INVALID_PARAMETERS.message + ': ' + error.message }));

Then core event is emitted and handled here:

connect/src/js/env/node/index.js

Lines 54 to 66 in b945218

	case RESPONSE_EVENT :
	if (messagePromises[id]) {
	// resolve message promise (send result of call method)
	messagePromises[id].resolve({
	id,
	success: message.success,
	payload,
	});
	delete messagePromises[id];
	} else {
	_log.warn(`Unknown message id ${id}`);
	}
	break;

As a result, promise is deleted from messagePromises on line 62 above which causes runtime error on line 104:

connect/src/js/env/node/index.js

Lines 95 to 104 in b945218

	const postMessage = (message: any, usePromise: boolean = true): ?Promise<void> => {
	if (!_core) {
	throw new Error('postMessage: _core not found');
	}
	if (usePromise) {
	_messageID++;
	message.id = _messageID;
	messagePromises[_messageID] = createDeferred();
	_core.handleMessage(message, true);
	return messagePromises[_messageID].promise;