This repository has been archived by the owner on Nov 23, 2023. It is now read-only.
bitcoin: add hex support to sign message. #522
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move hex utils from ethereumUtils to formatUtils.
This was referenced Jan 28, 2020
Closed
nodech
added a commit
to nodech/connect
that referenced
this pull request
Jan 28, 2020
nodech
added a commit
to nodech/connect
that referenced
this pull request
Jan 28, 2020
nodar-chkuaselidze/signMessage-withHex
nodech
added a commit
to nodech/connect
that referenced
this pull request
Jan 28, 2020
This was referenced Feb 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to optionally pass hex string to sign message.
Also moved hex utilities to format utilities (I noticed they are generic, not ethereum related)
This introduces a way to pass hex string instead of normal string for signing binary messages. The API is same as for ethereumSignMessage, where you have to pass optional
hexparameter when you pass hex string inmessage. Ifhexisfalse, it will behave the same way as before.Unrelated to this, but I noticed two tests are failing on Ripple (These are failing on
developbranch as well): #523