This repository has been archived by the owner on Nov 23, 2023. It is now read-only.
filter custom connectSrc #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prusnak
suggested changes
Apr 2, 2020
src/js/data/ConnectSettings.js
Outdated
| // `trezord` will block communication anyway | ||
| export const corsValidator = (url?: string) => { | ||
| if (typeof url !== 'string') return; | ||
| if (url.match(/^https:\/\/([a-zA-Z0-9-_])*.trezor.io\//)) return url; |
There was a problem hiding this comment.
This should be /^https:\/\/([A-Za-z0-9\-_]+\.)*trezor\.io\//
in the original regex, the following did not work:
https://trezor.io/(please add to test below)https://sub.dom.trezor.io/(please add to test below)
and this worked:
https://testxtrezorxio/(please add to test below)
src/js/data/ConnectSettings.js
Outdated
| if (typeof url !== 'string') return; | ||
| if (url.match(/^https:\/\/([a-zA-Z0-9-_])*.trezor.io\//)) return url; | ||
| if (url.match(/^https?:\/\/localhost:[58][0-9]{3}\//)) return url; | ||
| if (url.match(/^https:\/\/([a-zA-Z0-9-_])*.sldev.cz\//)) return url; |
There was a problem hiding this comment.
This should be /^https:\/\/([A-Za-z0-9\-_]+\.)*sldev\.cz\//
same reason as above, please add to tests too
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.